Repository navigation
Keep public CA files readable in Linux installer tests - #25
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The isolated installer test uses umask 077 for temporary secrets. Copying the public CA directory under that umask also produces mode 0700 directories and 0600 public files, preventing non-root Linux services from reading their trust configuration.
Give only the copied public trust directory mode 0755 and its two public configuration files mode 0644. Keep temporary secrets private. Include already-redacted service logs in failure diagnostics so future startup failures show their cause.
Validation: reproduced the unreadable-file failure as a non-root user on Linux; verified the real copied public CA/config files become readable while a synthetic private env file remains unreadable. Shell syntax, diff whitespace and all 7 release-tool tests passed. Full isolated product smoke test is also being run; final CI required before merge.