Repository navigation
Keep pending import approvals visible and retain approved diffs in a log - #2
Merged
Merged
Conversation
maxwellsdm1867
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Import review shows only pending or stale protocol proposals in its main approval view. Approved updates move into a collapsed history log: each entry reopens the original before/after diff and shows Approved. Persisted approval events keep older comparisons available after newer proposals replace them.
The import page keeps a compact Review import shortcut. Completed cards no longer remain expanded on the page.
Validation: 211 frontend tests, 10 suggestion tests, 8 import API tests, and production build passed. A regression verifies newer proposals do not erase prior approved comparisons. Browser verified the compact shortcut, collapsed approval log, and reopening an approved visual diff.