Repository navigation
chore(ci): track the latest Go 1.26 patch - #131
Merged
Merged
Conversation
govulncheck failed on every pull request after Go 1.26.9 fixed seven standard-library advisories, because CI pinned Go 1.26.6. The server image builds with golang:1.26-alpine, which already uses the newest 1.26 patch, so CI also scanned a different Go than the one we ship. Use the newest 1.26 patch in CI to match the image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
server-testsfails on every pull request.govulncheckreports seven Gostandard-library advisories in
net/http,net/textproto, andcrypto/tls.Go 1.26.9 (released 2026-10-08) fixes all of them, but CI pins Go 1.26.6.
CI also scanned a different Go than the one we ship:
server/Dockerfilebuilds with
golang:1.26-alpine, which always uses the newest 1.26 patch.Change
CI now uses
go-version: '1.26.x'withcheck-latest: true, so it scans andtests with the same Go patch that builds the server image.
Impact
the newest Go 1.26 patch.
Verification
Ran the
server-testsjob steps locally with Go 1.26.9:go vet ./...: passgo test -race ./...: all packages passgovulncheck ./...: "No vulnerabilities found."