Repository navigation
chore(ci): move GitHub Actions and CI Node.js to 24 - #133
Merged
Merged
Conversation
The pinned action majors ran on the deprecated Node.js 20 runtime. Update each action to its newest major, which runs on Node.js 24. No input that the workflows use was renamed or removed. CI and the release smoke test installed the worker on Node.js 20, but the Playwright base image ships Node.js 24. Use Node.js 24 so CI tests the runtime we ship. Add a grouped weekly Dependabot update for GitHub Actions, so the action versions stop going stale.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GitHub forces them onto Node.js 24 with a warning.
Playwright base image (
mcr.microsoft.com/playwright:v1.64.1) shipsNode.js 24. CI did not test the runtime we ship.
Change
Update each action to its newest major, which runs on Node.js 24:
actions/checkoutactions/setup-goactions/setup-nodeactions/upload-pages-artifactactions/deploy-pagesdocker/build-push-actiondocker/setup-buildx-actiondocker/setup-qemu-actiondocker/login-actiondocker/metadata-actionsoftprops/action-gh-releaseThe release notes of every major in between show no input that these
workflows use as renamed or removed, and no default that they rely on as
changed.
Use
node-version: '24'inci.ymlandrelease.yml.Add a weekly, grouped Dependabot update for GitHub Actions.
Impact
website.yml.That run exercises
upload-pages-artifactv5 anddeploy-pagesv5.release.yml(login, metadata, QEMU, and releaseactions) runs only on a version tag, so the next release exercises it.
Verification
scripts/check-playwright-version.jspass.actionlintv1.7.7: no new findings. It reports twoSC2034warnings(unused retry-loop variable) that also exist on
main.