fix: replace barrel exports with named exports and eliminate module-level side effects#33
Merged
Merged
Conversation
…evel side effects
- utils/index.ts: replace 11 export * with explicit named exports
for better tree-shaking (Vite/Rollup can skip unused sub-modules)
- runtime/index.ts: replace export * from '@mcbe-mods/utils' with
explicit named exports to match utils' new export style
- protocol/protocol.ts: move const log = new Log('Protocol') from
module top-level into constructor to eliminate module-level side
effect that prevented tree-shaking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
export *with explicit named exportsfor better tree-shaking (Vite/Rollup can skip unused sub-modules)
export * from '@mcbe-mods/utils'withexplicit named exports to match utils' new export style
const log = new Log('Protocol')frommodule top-level into constructor to eliminate module-level side
effect that prevented tree-shaking