Move TrustedParserOptions to TrustedHTMLParserOptions - #30463
Conversation
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
Elchi3
left a comment
There was a problem hiding this comment.
This seems all reasonable to me. The only thing is that I have no Chrome 155 beta yet and so I can't tell if it is really shipping.
|
Yeah it was original in 154 (and even made the 154 beta!) but this TrustedHTMLParserOptions change made us decide to not rush it in for 154 with this last minute change and instead include in 155. If you prefer I can leave it as behind a flag for now and just do the TrustedParserOptions -> TrustedHTMLParserOptions change in this PR? Or can leave this open for a week until the 155 beta is out. |
|
Yeah, if you want this PR to land then just the renaming would be great. Ideally the collector run for 155 beta should pick up this as shipping next week then. But you can also leave this PR open as is and we get to it next week when we have the 155 beta. As you prefer :) |
|
No real urgency for this to land as the But I thought it would mess up your collector if that didn't land. So let's land it and let the collector manage the 155 update. Have reverted the other changes now. PTAL. |
Co-authored-by: Florian Scholz <fs@florianscholz.com>
|
The lint check found auto-fixable issues. Apply suggested changes (attributed to |
fwiw, I am not seeing this enabled in Chrome 155 beta that is available now. |
|
Confirmed! Thanks for spotting that. Chasing with engineering now... |
|
FYI, @Elchi3 this has been pushed back to 157 now due to some other changes as part of standardisation. |
Summary
A follow on to #30328 with the following changes:
TrustedParserOptionswas renamed toTrustedHTMLParserOptionsas part of standardisation review (note this is not complete yet) - w3c/trusted-types@b97634f. FYI @Elchi3 as think you might have manually added this t the BCD collector?Test results and supporting details
https://wpt.fyi/results/domparsing/tentative?label=experimental&label=master&aligned
https://chromestatus.com/feature/5054329641893888
Related issues
A follow on to #30328
Web Features (referencing these keys, including
TrustedParserOptions) - web-platform-dx/web-features#4318