bench: read streams from disk - #94
Merged
Merged
Conversation
francisdb
force-pushed
the
bench/read-disk
branch
from
September 10, 2026 06:14
3a128a5 to
0cd71e8
Compare
The read benches only covered memory, which hides the per-call cost of an unbuffered File. Add a disk read group with a short measurement window.
francisdb
force-pushed
the
bench/read-disk
branch
from
September 10, 2026 06:20
0cd71e8 to
1fafa21
Compare
francisdb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The read benches only covered memory, which hides the per-call cost of an unbuffered
File, the typecfb::openhands out. Reading the file with 10000 empty streams takes 46 ms from disk against 7 ms from memory on master, and that gap is invisible today.This adds a
read_streams_diskgroup over the same cases as the write one, with a 1 second warm-up and a 2 second measurement window so it adds about 25 seconds to a full run.