feat(logs): less slow syslog.db rotation - #1576
Open
tcely wants to merge 12 commits into
Open
Conversation
tcely
marked this pull request as ready for review
August 30, 2026 18:20
tcely
force-pushed
the
tcely-log-finish
branch
from
August 31, 2026 06:46
fd4feed to
c6419aa
Compare
tcely
force-pushed
the
tcely-log-finish
branch
from
August 31, 2026 13:48
a838f56 to
f16c997
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have opened an issue (12) upstream for the less than ideal rotation experience.
This differs from the rotation in the source code by having duplicate rows in the archive. I deem that acceptable because it's better to have a bit too many and be much faster, than to be precise to the row number and significantly slower.
References