Skip to content

Clean up Bats workflow warnings #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merefield merged 2 commits into from
Aug 23, 2026
Merged

Clean up Bats workflow warnings #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94282da
Clean up Bats workflow setup
merefield Aug 23, 2026
b004078
Harden Windows fixture startup
merefield Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,13 @@ jobs:

- name: Setup Bats
if: runner.os == 'Linux'
uses: bats-core/bats-action@3.0.1
uses: bats-core/bats-action@4.0.0
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
support-install: false
assert-install: false
detik-install: false
file-install: false

- name: Check formatting
if: runner.os != 'Windows'
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,13 @@ jobs:
cache: true
- name: Setup Bats
if: runner.os == 'Linux'
uses: bats-core/bats-action@3.0.1
uses: bats-core/bats-action@4.0.0
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
support-install: false
assert-install: false
detik-install: false
file-install: false
- name: Check formatting
if: runner.os != 'Windows'
shell: bash
Expand Down
9 changes: 6 additions & 3 deletions test/install-release.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,15 @@ with open(sys.argv[2], "w", encoding="ascii") as port_file:
server.serve_forever()
'@
$serverProcess = Start-Process -FilePath $python.Source -ArgumentList @($serverScript, $serverRoot, $portFile) -PassThru
for ($attempt = 0; $attempt -lt 50 -and -not (Test-Path -LiteralPath $portFile); $attempt++) {
$port = ""
for ($attempt = 0; $attempt -lt 50; $attempt++) {
if ($serverProcess.HasExited) { throw "fixture HTTP server exited before reporting its port" }
if (Test-Path -LiteralPath $portFile) {
$port = ([string](Get-Content -LiteralPath $portFile -Raw)).Trim()
if ($port -match '^\d+$') { break }
}
Start-Sleep -Milliseconds 100
}
if (-not (Test-Path -LiteralPath $portFile)) { throw "fixture HTTP server did not report its port" }
$port = (Get-Content -LiteralPath $portFile -Raw).Trim()
if ($port -notmatch '^\d+$') { throw "fixture HTTP server reported an invalid port: $port" }
$baseUrl = "http://127.0.0.1:$port"
$webRequestArgs = @{}
Expand Down