Repository navigation
docs(spec): Calendar weekday headers show the abbreviated names - #9072
imdreamrunner wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
PR Analysis Report
Generated by PR Enrichment workflow | View current CI run |
There was a problem hiding this comment.
Approval waits on an owner decision. DD1 adds a weekday-header rule that no current spec on main states yet: whole abbreviated names, including full words in Arabic and European Portuguese. An engineering owner records that decision by commenting /approve-spec 986546d4aabca741c217874492d0537e4ccab3ba on this pull request, and the author may do so if they are an engineering owner. Two record fixes are needed whatever the decision:
Calendar.spec.mdline 59 still says the released default is preserved, although DD1 changes every Calendar's header text.- The DD1 verification row tests English and one other locale, but English and the Spanish locale the current tests use both have three-letter abbreviations, so a header cut to three characters would still pass; name a locale with longer abbreviations, such as
plorpt-PT.
[Automated review]
| @@ -57,8 +57,8 @@ keyboard model that moves through days; date fields compose it. | |||
| ## Compatibility and migration | |||
|
|
|||
| - Released default preserved: `yes` | |||
There was a problem hiding this comment.
DD1 changes every Calendar's weekday headers from the short to the abbreviated names, with no prop to keep the short form, and line 45 already says the record departs from shipped behavior for that. This line should say so too, for example "yes, except DD1: no", naming the header change.
There was a problem hiding this comment.
Fixed in fd7a6ba: the row now requires a locale whose abbreviated names run past three characters, such as pl or pt-PT.
| | FR6 | `Calendar.test.tsx` navigation, bound, theming-target ("renders the astryx-calendar-nav target on both month-nav buttons", "reflects the disabled nav state as a data attribute at the range edges", "keeps the default nav rendering unchanged (still a ghost icon button)"), and RTL month-navigation cases | Previous and Next; at `min` and `max`; `dir="rtl"` | A button enabled past a bound, a missing `calendar-nav` target or state attribute, or a lost shared chevron wrapper fails. Evidence gap: no test asserts focus kept at a bound (the FR6 gap), the mirrored chevron pixels, or the press under reduced motion. | `audit:Calendar/behavior` | | ||
| | FR7 | `Calendar.test.tsx` month-change announcement cases ("does not announce on initial render", "announces the new month politely when clicking next", "announces the next month when paging the grid with PageDown", "announces both months in a two-month view", "does not announce when selecting a date leaves the visible month unchanged") and range announcement cases ("announces the start pick and prompts for an end date", "announces the completed range in chronological order for a reverse pick") | Month buttons, Page keys, handle; single and two months; range start, complete, cleared | A missing, extra, or out-of-order announcement fails. Evidence gap: no test reaches the cleared-start announcement (the cleared-range case sets no `minRangeSpan`). | `audit:Calendar/accessibility` | | ||
| | FR2 (size) | Evidence gap: no test asserts day-button size or text growth | — | — | `audit:Calendar/layout` | | ||
| | DD1 | Evidence gap: the `Calendar.test.tsx` day-name cases ("displays day names", "uses the provider locale for stand-alone short day names", "rotates localized day names by numeric weekday index") assert the short names | English and one other locale; `weekStartsOn` rotation; with week numbers | A header showing a short name, or a name cut to three characters, fails. | `audit:Calendar/layout` | |
There was a problem hiding this comment.
English and es-ES (the locale the existing day-name cases use) both have three-letter abbreviated names, so a header cut to three characters would pass this row. Naming a second locale with longer abbreviations, such as pl or pt-PT, makes the stated failure detectable.
There was a problem hiding this comment.
Fixed in fd7a6ba: the row now requires a locale whose abbreviated names run past three characters, such as pl or pt-PT.
There was a problem hiding this comment.
Approval waits on a spec owner deciding DD1 as the governing spec for Calendar's weekday headers: no current spec on main states that rule yet, and it shows whole abbreviated names, including full words in Arabic and European Portuguese that overrun the 32px day column. To settle it, an engineering owner comments /approve-spec fd7a6bae09fa026c2d5f78bf8f1604a87e714465 on this pull request (the author may do so as an engineering owner), or the owners ask for a shorter form in those locales; the repository's design-decision routing also asks for a design owner's review. The two record fixes from the earlier review are in, and nothing else needs to change.
[Automated review]
fd7a6ba to
c740152
Compare
There was a problem hiding this comment.
Approval waits on a spec owner deciding DD1 as the governing spec for Calendar's weekday headers: no current spec states the abbreviated-width rule yet, and it shows whole names, including full words in Arabic and European Portuguese that are wider than the 32px day column. To settle it, an engineering owner comments /approve-spec c74015220a9aa3e3ce184fc8e500fdb196f01d8a on this pull request (the author may do so as an engineering owner), or the owners ask for a shorter form in those locales; the repository's design-decision routing also asks for a design owner's review. Nothing else in the record needs to change.
[Automated review]
Exact decision needed
Which form of the weekday name Calendar's column headers show.
Existing authority searched
component:Calendar(current,docs/specs/components/Calendar/Calendar.spec.md): FR1 says only that weekday names come from the provider locale.architecture:internationalizationcovers locale data but not name width. No current record settles the form.Su–Sain English). The touch date field's sheet already uses the abbreviated width (Sun–Sat).Decision
component:CalendarDD1: each weekday column header shows the provider locale's stand-alone abbreviated weekday name (the CLDRabbreviatedwidth) in full, soSun–Satin English. FR1 points to DD1. The headers still render the short names today, so the DD1 row, Current-state impact, and a verification-map evidence gap record that as an implementation gap. This PR changes no code.Rejected alternatives
Rejected:line in DD1.Claim scope and non-goals
Evidence and implementation relationship
TuandTh, orSaandSu, easy to confuse.Intl/CLDR):arandpt-PTuse full words (الثلاثاء,segunda), andhe(יום א׳),pl(niedz.),vi(Thứ 2),da,fr,pt, androalso run longer.Question for design review
@rubyycheung, could you review this? It's the 3-letter weekday change you asked for. One call is yours: in Arabic and European Portuguese the abbreviated name is a full word, and DD1 shows it in full in the narrow day column. Should those locales keep the shorter form instead?
Writing rubric results
Scope
Validation
pnpm check:knowledge: alignedgit diff --check: cleanmainafter the Calendar record became current and moved underdocs/specs/components/.