Repository navigation
refactor: use Node.js 26 built-ins for locale calendars and the MDX processors cache (AI-assisted) - #12831
Open
slorber wants to merge 1 commit into
Open
refactor: use Node.js 26 built-ins for locale calendars and the MDX processors cache (AI-assisted)#12831slorber wants to merge 1 commit into
slorber wants to merge 1 commit into
Conversation
…rocessors cache (AI-assisted) - Intl.Locale: V8 14.6 removed the non-standard `calendars` getter, use `getCalendars()` - MDX processors cache: use `Map.prototype.getOrInsertComputed()` Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
slorber
added
the
pr: maintenance
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Processor cache creation packages/docusaurus-mdx-loader/src/processor.ts |
createProcessorsCacheEntry now uses ProcessorsCache.getOrInsertComputed for cache lookup and creation. |
Default calendar
| Layer / File(s) | Summary |
|---|---|
Calendar selection packages/docusaurus/src/server/i18n.ts |
getDefaultCalendar returns the first calendar from locale.getCalendars(), or 'gregory' when the returned list is empty. |
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Refactor
Possibly related PRs
- meta/docusaurus#12821: This PR raises the Node.js runtime floor for the built-in APIs used by both changes.
Merge Risk: 
2ad76
-
No actionable compatibility or runtime risk is established for this refactor.
Architecture risk: 
2ad76
-
The change affects 2 systems.
Changed systems:
packages/docusaurus,packages/docusaurus-mdx-loaderArchitecture concerns
No architecture-level concerns identified.Review details
-
Systems and components
- observed — packages/docusaurus (library) was modified; 1 changed file maps to changed impact.
- observed — packages/docusaurus-mdx-loader (library) was modified; 1 changed file maps to changed impact.
Before / after behavior
- observed — Modified behavior in packages/docusaurus-mdx-loader/src/processor.ts:
createProcessorsCacheEntrynow returns the result ofProcessorsCache.getOrInsertComputed, replacing the explicit cache lookup and conditional creation and insertion. - observed — Modified behavior in packages/docusaurus/src/server/i18n.ts:
getDefaultCalendarnow useslocale.getCalendars()directly and returns its first calendar, defaulting to'gregory'when the list is empty. The previous optional-method check and fallback tolocale.calendarsare removed.
-
Pre-merge checks: 
-
Check name Status Explanation Resolution Docstring Coverage Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Write docstrings for the functions missing them to satisfy the coverage threshold. -
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly identifies both main changes: using Node.js 26 built-ins for locale calendar lookup and the MDX processors cache. The title is specific and related to the changeset. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 2 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: 0 B Total Size: 12.1 MB ℹ️ View Unchanged
|
|
Size Change: 0 B Total Size: 12.1 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Use built-ins that Node.js 26 (V8 14.6) brings, now that it's the minimum version:
Intl.Locale.prototype.calendarsgetter (it returnsundefinedon Node 26.13), so our fallback to it was dead code. We now call the standardgetCalendars()directly.Map.prototype.getOrInsertComputed()replaces the manual get-then-set.Not included:
util.debounce()(Node 26.10) could replace_.debounce()in the dev server reload, but the latest@types/node(26.6.6) doesn't type it yet.Test Plan
fa→persian,th→buddhist).pnpm test,pnpm typecheck:testsandpnpm lintpass locally on Node 26.13.0.Test links
Deploy preview: https://deploy-preview-12831--docusaurus-2.netlify.app/
Related issues/PRs
(AI-assisted)
🤖 Generated with Claude Code
Summary by CodeRabbit