Skip to content

[Nexthop][feature] "asic_config_v3" - Support all four config_gen_type values - #1789

Open
marif-nexthop wants to merge 1 commit into
meta:mainfrom
nexthop-ai:marif.fboss-asic-config-v3-config-gen-type
Open

marif-nexthop wants to merge 1 commit into
meta:mainfrom
nexthop-ai:marif.fboss-asic-config-v3-config-gen-type

Conversation

@marif-nexthop

@marif-nexthop marif-nexthop commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run

Summary

Implements asic_config_v3 design.

In this PR, support all four AsicConfigGenType values.

  • The platform schema accepts BENCHMARK and LINK_TEST in addition to DEFAULT and HW_TEST.
  • The content validator reads BENCHMARK references from fboss/oss/hw_bench_configs and LINK_TEST references from fboss/oss/link_test_configs.

Also made change in the generator so that config_gen_type is fully data-driven.

  • The uncached port statistics setting for the test profiles moves from the Tomahawk5 ASIC file into the wedge800bact and montblanc platform files, keyed on HW_TEST and LINK_TEST.
    This confirms to the design that the ASIC file describes the silicon and platform file decides what a test profile needs.

This PR is stacked on #1736

Test Plan

Regenerated every platform with the asic_config_v3 generator. The only outputs that changed are the two hw_test.yml files, where sai_uncached_port_stats moves after the keys written by the ASIC-level conditional settings.

Ran the content validator:

Summary:
  Platforms: 9
  Variants: 14
  BYTE_MATCH: 9
  SEMANTIC_MATCH: 5
  CONTENT_MISMATCH: 0

Validated the ASIC and platform configs against the schemas:

15 passed, 0 failed

@meta-cla meta-cla Bot added the CLA Signed label Oct 15, 2026
@github-actions github-actions Bot added nexthop project:feature FBOSS project: feature labels Oct 15, 2026
@marif-nexthop
marif-nexthop force-pushed the marif.fboss-asic-config-v3-config-gen-type branch 3 times, most recently from d0095d8 to 256adc3 Compare October 15, 2026 07:42
@marif-nexthop
marif-nexthop marked this pull request as ready for review October 15, 2026 07:43
@marif-nexthop
marif-nexthop requested review from a team as code owners October 15, 2026 07:43
@marif-nexthop
marif-nexthop force-pushed the marif.fboss-asic-config-v3-config-gen-type branch from 256adc3 to acbd2b4 Compare October 20, 2026 03:26
@marif-nexthop
marif-nexthop force-pushed the marif.fboss-asic-config-v3-config-gen-type branch from acbd2b4 to 744897f Compare October 22, 2026 18:37

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant