Repository navigation
Conversation
…case where the types is overaligned.
…case where the types is overaligned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProducerConsumerQueueallocates its ring withstd::malloc, which only guaranteesalignof(std::max_align_t). ATwith a stricteralignasis then constructed on misaligned storage. This is undefined behavior, may crash: analignas(32)__m256dstruct built with-mavx2segfaults on an alignedvmovapdstore.Over-aligned
Tnow usesfolly::operator_newandfolly::operator_deletewithstd::align_val_t. Other types keepstd::mallocandstd::free. There is no change to the public API or object layout. Generated code forProducerConsumerQueue<long>is identical before and after.