Repository navigation
sync: send hdr and handle missing metadata in add_to_collection - #323
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trakt's contract now documents that
sync/collectionadd clears metadata a request leaves out (trakt/trakt-api ae20b2f). Two problems insync -a add_to_collection:Fixed
hdrfrom an export made with-ex metadatawas never sent: noUpdateCollectedDatainstr/copiedMetadata.Hdr, so re-adding an export could clear the HDR format. It is now sent with the other metadata.add_to_collection -t showswith an export made without-ex metadatacrashed with a nil pointer error (season episodes withoutmetadata). Those episodes are now sent without metadata.Tests
str/export_list_item_test.go:hdrcopied by all five methods; season episode withoutmetadata/collected_at.handlers/commons_pure_test.go: both export shapes throughConvertBytesToItemsListforadd_to_collection.Live check (2026-11-04)
existing.episodes=86,added/updated0,not_foundempty; before the fix it crashed before the request.hdris mock-tested only: no collected item on the test account has HDR set.AI (Claude Code) traced the contract change to the bugs, wrote the fix, tests, CHANGELOG entry and the live-check script; I ran the live check.