Skip to content

Fix updater value buffer isolation - #49

Open
Daniiiil1 wants to merge 1 commit into
micro-ROS:masterfrom
Daniiiil1:codex/fix-updater-buffer-isolation
Open

Fix updater value buffer isolation#49
Daniiiil1 wants to merge 1 commit into
micro-ROS:masterfrom
Daniiiil1:codex/fix-updater-buffer-isolation

Conversation

@Daniiiil1

Copy link
Copy Markdown

Summary

  • move the diagnostic key-value buffer from file-static storage into each diagnostic_updater_t instance
  • set the ROS sequence capacity in elements rather than bytes
  • add a regression test that initializes two updaters and verifies their buffers cannot alias or overwrite each other
  • add the contributor entry required by CONTRIBUTING.md

Testing

  • ament uncrustify configuration check passed for the changed C, C++, and header files
  • git diff --check
  • the added gtest is exercised by the repository Humble and Rolling CI matrix

Fixes #39

Signed-off-by: Daniil Mordanov <153565951+Daniiiil1@users.noreply.github.com>
@Daniiiil1
Daniiiil1 marked this pull request as ready for review August 7, 2026 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

key_value_buffer is static and would cause issues if two updaters are created

1 participant