Add context-aware diagnostic tasks - #51
Open
Daniiiil1 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Daniil Mordanov <153565951+Daniiiil1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rclc_diagnostic_task_init_with_contextfor callbacks that need instance-specific staterclc_diagnostic_task_initsource-compatible and explicitly initialize its new fieldsThe API follows the existing rclc pattern: the context pointer is supplied after the callback during initialization and is passed as the callback's final argument. A null context is allowed; a null callback is rejected.
Closes #15.
Validation
git diff --checkcppcheckon the changed C/C++ implementation, example, and tests (only pre-existing warnings outside the new code)The local machine does not have a ROS 2 / colcon workspace, so the Humble and Rolling builds and gtests are delegated to the repository CI.