build(deps): bump @kikobeats/got to ~11.8.8 - #287
Conversation
11.8.8 restores the 11.8.6 write lock (11.8.7 let a stray write inject a second request on a keep-alive connection), keeps retrying connection errors reported through the end callback on Node.js 24.20+, and fixes cached requests crashing with cacheable-request forks bundling clone-response@2. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VZiY7VMgg1nEMkCezwMXEC
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe pull request updates the ChangesDependency Update
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other Merge Risk: ⚪ Minimal · up to No actionable merge-blocking risk is established by the dependency-only change. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Picks up
@kikobeats/got@11.8.8, which fixes issues found by seven adversarial reviews of the fork after 11.8.7 shipped:write()on a stream that already had a body was accepted and reached the server as a second request on a keep-alive connection. It throws again, as in got 11.8.6.end()callback (ECANCELED,ERR_SOCKET_CLOSED) are handled after the request's own error, so connection failures retry instead of failing once.cacheable-requestforks that bundleclone-response@2. html-get does not use thecacheoption, so this one does not affect it directly.end()while a body stream is still sending throws instead of truncating the upload, and the source tracking no longer leaks listeners.Testing
lts/*)standardis clean. The fork's own suite passes 552 tests on Node.js LTS and latest, and html-get, reachable-url, oembed-spec, metascraper and the microlink-api unit suite were each run against this build with no failures that stock got does not also have.🤖 Generated with Claude Code
https://claude.ai/code/session_01VZiY7VMgg1nEMkCezwMXEC
Note
Low Risk
Single dependency patch with no application code changes; risk is limited to HTTP client behavior fixes in the fork used for all fetches.
Overview
Bumps
@kikobeats/gotfrom ~11.8.7 to ~11.8.8 — the only code change is inpackage.json. html-get still loads the fork fromsrc/index.jsfor page fetches; behavior comes from the updated dependency.11.8.8 restores the write-lock guard (avoids a stray second request on keep-alive after 11.8.7), improves retry handling on Node.js 24.20+ for
ECANCELED/ERR_SOCKET_CLOSED, fixes cache crashes with certaincacheable-requestforks (html-get does not usecache), and tightens upload/end()handling so bodies are not truncated and listeners do not leak.PR testing reports the existing suite passing on Node 24.16 and 24.20.
Reviewed by Cursor Bugbot for commit 72288ed. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit