Repository navigation
AL-Go Telemetry Enhancements: repository fork and hosting information - #2392
Open
Alexander Holstrup (aholstrup1) wants to merge 3 commits into
Open
Alexander Holstrup (aholstrup1) wants to merge 3 commits into
Alexander Holstrup (aholstrup1) wants to merge 3 commits into
Conversation
Add separate getters for repository fork status and GitHub hosting classification, with common telemetry dimensions, documentation, and unit coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Alexander Holstrup (aholstrup1)
requested a review
from a team
as a code owner
October 6, 2026 09:54
Copilot started reviewing on behalf of
Alexander Holstrup (aholstrup1)
October 6, 2026 10:04
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation is resilient, documented, privacy-conscious, and comprehensively tested across supported PowerShell environments.
Review effort: Balanced
Findings: None
What changed in this PR
Adds repository fork status and GitHub hosting classification to common AL-Go telemetry.
Changes:
- Adds resilient telemetry getters with
Unknownfallbacks. - Adds 27 cross-platform Pester test cases.
- Documents the new dimensions and release impact.
| File | Description |
|---|---|
Actions/TelemetryHelper.psm1 |
Collects and attaches the new dimensions. |
Tests/TelemetryHelper.Test.ps1 |
Tests classification, invalid metadata, and integration. |
Scenarios/EnablingTelemetry.md |
Documents behavior and privacy limitations. |
RELEASENOTES.md |
Announces the telemetry enhancement. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Emit action names and wrapper-owned conclusions, cover handled errors and skipped telemetry, and document the dimensions. Suppress Pester scope false positives using the repository's existing analyzer pattern. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Alexander Holstrup (aholstrup1)
enabled auto-merge (squash)
October 6, 2026 12:55
Jonas Blunck (jonasblunck)
approved these changes
Oct 6, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❔What, Why & How
Add repository and hosting context to AL-Go telemetry so consumers can distinguish workflows running in forks and across GitHub hosting environments.
Separate
Get-RepositoryIsForkandGet-GitHubHostingTypegetters populate common dimensions for both Microsoft and partner telemetry, respecting existing telemetry settings:RepositoryIsFork:trueorfalsefrom the workflow event'srepository.fork, not the pull request source repository.GitHubHostingType:GitHub.com,GHECfor*.ghe.com, orGHESfor other valid HTTP(S) hosts.Missing or invalid metadata produces a warning and
Unknownwithout blocking existing telemetry. Server hostnames and URLs are not added to telemetry.Classification limitation: The
GHESfallback is a hostname-based heuristic, not positive identification through the GitHub API. GitHub.com also includes Enterprise Cloud customers hosted there; this does not identify subscription plans.Added scenario documentation, release notes, and 27 unit tests passing on both PowerShell 7 and Windows PowerShell 5.
Related to issue: N/A
✅ Checklist