Skip to content

Prevent workflow telemetry failures from failing the workflow - #2395

Merged
Alexander Holstrup (aholstrup1) merged 1 commit into
mainfrom
aholstrup1-irs-forms-upgrade-issue
Oct 6, 2026
Merged

Alexander Holstrup (aholstrup1) merged 1 commit into
mainfrom
aholstrup1-irs-forms-upgrade-issue

Conversation

@aholstrup1

Copy link
Copy Markdown
Collaborator

❔What, Why & How

WorkflowPostProcess only collects telemetry, but a GitHub API 502 left a nonzero gh exit code and failed an otherwise successful BCApps run during finalization.

Set continue-on-error: true on the composite action's telemetry step so these failures remain visible in logs without failing the workflow. Actual build/test status checks remain unchanged. Update the YAML regression check, action documentation, and release notes.

Validation: all 9 targeted WorkflowPostProcess and PullRequestStatusCheck tests passed on Windows PowerShell 5 and PowerShell 7.

Related to issue: N/A. Observed in this BCApps workflow run.

✅ Checklist

  • Add tests (E2E, unit tests)
  • Update RELEASENOTES.md
  • Update documentation (e.g. for new settings or scenarios)
  • Add telemetry - N/A; existing telemetry is retained.

Allow the telemetry-only composite step to fail without failing the workflow, while preserving actual PR status checks. Update YAML regression coverage and documentation.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 6, 2026 12:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The implementation is focused, documented, and covered by the existing YAML regression test.

Review effort: Balanced
Findings: None

What changed in this PR

Prevents telemetry-only finalization failures from failing otherwise successful workflows.

Changes:

  • Makes WorkflowPostProcess non-blocking.
  • Extends YAML regression coverage.
  • Updates documentation and release notes.
File Description
Actions/​WorkflowPostProcess/​action.yaml Allows telemetry-step failures.
Actions/​WorkflowPostProcess/​README.md Documents non-blocking behavior.
Tests/​WorkflowPostProcess.Test.ps1 Verifies the new YAML setting.
Tests/​TestActionsHelper.psm1 Adds support for asserting continue-on-error.
RELEASENOTES.md Announces the reliability fix.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@aholstrup1
Alexander Holstrup (aholstrup1) merged commit ba1b347 into main Oct 6, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants