Repository navigation
Fix internal SDK Stats network metric names - #2775
Merged
Jackson Weber (JacksonWeber) merged 2 commits intoOct 5, 2026
Merged
Jackson Weber (JacksonWeber) merged 2 commits into
Jackson Weber (JacksonWeber) merged 2 commits into
Conversation
Align failure, retry, and exception metrics with Statsbeat names and verify their existing dimensions and aggregation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Jackson Weber (JacksonWeber)
October 3, 2026 02:09
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The failure metric uses Requests_Failure_Count instead of the Statsbeat-defined Request_Failure_Count.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Aligns internal SDK Stats network telemetry with Statsbeat naming and strengthens aggregation/dimension assertions.
Changes:
- Renames failure, retry, and exception metrics.
- Adds exact metric aggregation and dimension checks.
- Updates buffered exception integration expectations.
| File | Description |
|---|---|
shared/AppInsightsCore/src/core/InternalSdkStats.ts |
Updates emitted network metric names. |
shared/AppInsightsCore/Tests/Unit/src/ai/InternalSdkStats.Tests.ts |
Expands metric and dimension coverage. |
AISKU/Tests/Unit/src/SdkStatsFeature.tests.ts |
Updates the buffered exception expectation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Use Request_Failure_Count to match the Azure Monitor JS and Java exporters, and update the core test expectation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Hector Hernandez (hectorhdzg)
approved these changes
Oct 5, 2026
Nev (MSNev)
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align failure, retry, and exception metrics with Statsbeat names and verify their existing dimensions and aggregation.