-
Notifications
You must be signed in to change notification settings - Fork 825
FEAT: Add Local File Dataset Configuration for Dataset Tinkering #2285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ValbuenaVC
wants to merge
7
commits into
microsoft:main
Choose a base branch
from
ValbuenaVC:vvalbuena-microsoft-dataset-tinkering
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+656
−44
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
8cd6b31
FEAT add local file dataset configuration
4fe4dd2
Merge branch 'main' into vvalbuena-microsoft-dataset-tinkering
ValbuenaVC 0912d7a
FEAT: Added tests and expanded _LocalFileDatasetAttackConfiguration
fcfef10
Precommit
3863701
FEAT warn on local dataset mutations
618a4fb
Merge branch 'main' into vvalbuena-microsoft-dataset-tinkering
ValbuenaVC 541df2b
Merge branch 'main' into vvalbuena-microsoft-dataset-tinkering
ValbuenaVC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This cell builds a config for a file that doesn't exist and then never uses it — it only "passes" because construction is lazy. The prose says "create or copy the scratch file first" but doesn't show how, while
doc/scanner/airt.pyhas thewrite_textbootstrap in a non-executed fence. Pick one treatment for both pages.Also
CONFIGURATION_DIRECTORY_PATHis~/.pyrit, where.envlives. Probably not where we want to steer people's scratch data.