FIX Avoid blocking WAV reads in realtime target - #2305
Open
romanlutz wants to merge 1 commit into
Open
Conversation
Move WAV loading to asyncio.to_thread so realtime audio sends do not block the event loop. Add coverage for the offloaded read and preserved payload metadata. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1c85c49c-2d6c-4050-b3e3-ce085c97c5ec
jsong468
reviewed
Aug 4, 2026
| raise NotImplementedError("RealtimeTarget uses receive_events for message construction") | ||
|
|
||
| @staticmethod | ||
| def _read_wav_file(filename: str) -> tuple[bytes, int, int, int]: |
Contributor
There was a problem hiding this comment.
NIT: do we want docstring for this?
jsong468
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
RealtimeTarget.send_audio_asyncperformed synchronouswave.open()andreadframes()calls on the event loop, which could stall concurrent realtime audio requests.This moves WAV loading into a synchronous helper executed with
asyncio.to_thread. The audio bytes and WAV metadata continue through the existing API payload and output-saving path unchanged.Tests and Documentation
tests/unit/prompt_target/target/test_realtime_target.py: 46 passed.git diff --checkpassed.