MAINT Deduplicate pretty output color formatting - #2318
Merged
romanlutz merged 1 commit intoAug 4, 2026
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 026dff00-745e-42fb-9748-5555ee006073
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Five pretty output printers carried identical ANSI line-formatting implementations, increasing maintenance cost and making behavior easier to drift. This change extracts that behavior into a narrow internal
_PrettyPrinterMixinwhile keeping each domain printer's public API, inheritance contract, and rendered output unchanged.All five pretty printers inherit the shared helper, leaving generic and domain-specific printer bases untouched. Focused coverage verifies exact colored output, disabled-color output, and the no-color argument path.
Tests and Documentation
uv run pytest tests\unit\output -q(188 passed)uv run ruff checkon changed filesuv run ruff format --checkon changed filesuv run ty checkon changed filesgit diff --checkDocumentation was not updated because this is an internal refactor with no public API or behavior change. JupyText was not applicable.