MAINT Simplify attack result queries - #2321
Merged
romanlutz merged 3 commits intoAug 4, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 647cdf27-3786-40a2-918c-b88f784fbc6d
…tack-result-queries
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 647cdf27-3786-40a2-918c-b88f784fbc6d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MemoryInterface.get_attack_resultshad accumulated filtering, batching, deduplication, and pagination branches in one large method. This refactors the implementation into a private immutable query object and focused condition-building helpers while preserving the existing public method signature as a compatibility wrapper.The SQLite and Azure SQL backend hooks remain unchanged, as do filtering semantics, recency ordering, keyset pagination, deduplication, turn bounds, and batched ID lookups. The internal query type is intentionally private so this maintenance refactor does not expand PyRIT's public API.
Tests and Documentation
Added focused tests for immutable input snapshots, keyword-only construction, complete wrapper forwarding, and parity between the compatibility wrapper and internal query executor.
Validated the affected memory, backend, analytics, scenario, and executor suites, plus Ruff,
ty, pre-commit hooks, andgit diff --check. Documentation was not changed because public behavior and APIs are unchanged. JupyText was not applicable.