[FIX]: Evaluate probe verdicts over final traces - #149
Draft
spencrr wants to merge 5 commits into
Draft
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes behavioral probes to evaluate the verdict once over the completed trace. Probes no longer stop on a detected verdict by default; callers can provide
stop_whenwhen an online condition should define an earlier terminal trace.This fixes sequence and prior-condition probes that cannot be resolved correctly from partial prefixes. Final verdict evidence is stored on
Result.evaluation, online stop evidence remains on turns, zero-turn runs returnERROR, and summaries use terminal rationale or evidence. Terminal evaluation stays inside the active session.Depends on #148. Because the branches live on a fork, this PR temporarily includes lower-layer diffs and targets
main; those diffs disappear as dependencies merge.Breaking changes
Behavioral change:
Result.eval_resultsis normally empty for probes withoutstop_when; useResult.evaluationfor verdict evidence. Adaptive drivers without an online stop receive no evaluator feedback and may run tomax_turns.Checklist
pre-commit run --all-filespassesValidation: 164 probe, driver, serialization, and report regressions pass; strict documentation build and static checks pass.