Repository navigation
Add automatic knowledge discovery, readiness checkpoints and integrated answering - #3226
Merged
Hillary Mutisya (hillary-mutisya) merged 3 commits intoOct 26, 2026
Merged
Conversation
Extract scoped discovery, readiness checkpoints, exact source-backed answering, protocol and Memory Hub wiring while preserving merged question and curation behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Preserve explicit nonready failures across transports, align the one-hour bounded timeout, and isolate pre-existing controlled View models from unrelated discovery calls. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Retain source progress and explicit preparation failures when a knowledge response cannot render; cover the complete Memory Hub client suite. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR3: automatic knowledge discovery, readiness checkpoints and integrated answering, based on main after #3224 and #3225.
sourceObserved. Policy admission does not confirm answers or authorize tools.Boundaries
Extracted feature commits and later scoped repairs from immutable integration source, reconciled against current main instead of replacing shared files with older versions. Preserves merged question inventories, answer-quality repairs and lazy topic behavior.
Excludes PR4's scoped graph APIs/projections/entity-event/hierarchy work, graph UI/RPC/MCP, generic Views/Inbox/navigation redesign and lazy read-projection optimizations. No PR4 branch dependency.
No live inference, pilot, replay, LongMemEval evaluation or performance qualification was run. The previous stopped pilot is not a completed qualification or scoring result.
Validation
Commands run from
tsunless a package directory is specified:pnpm run build— full workspace passed.pnpm run jest-esm --runInBand --testPathPattern='(knowledgeCoordinator|knowledgeDiscovery|knowledgeLifecycle|knowledgeAnswering|integratedAnswer|schemaViews|topicService|viewBuilds|viewDrafts|informationalWiki|viewSynthesisEvidence|wikiContribution)[.]spec[.]js'— 301 tests passed.pnpm run jest-esm --runInBand --testPathPattern='(answerKnowPro|fileMemoryService|markdownPersistence|maintenanceScheduler|topicGeneration|topicFamily|corpusIngestionIsolation)[.]spec[.]js'— 86 tests passed.pnpm --filter @typeagent/memory-client test:local— 49 passed.pnpm --filter @typeagent/memory-mcp-server test:local— 38 passed; aligned timeout/controlled-model fixtures additionally rechecked with focused knowledge/inventory tests.pnpm run test:views:gateway— 102 passed; final timeout RPC test additionally rechecked.pnpm run test:views:client -- --testPathPattern='memoryHub(KnowledgeStatus|Questions|Search)[.]test[.]ts'— 53 passed;pnpm run test:views:client— all 339 tests passed after adding malformed-status isolation.node --test tools\memory-maintenance-qualification\longmemeval-runner.test.mjs tools\memory-maintenance-qualification\ingestion-profile.test.mjs— 43 deterministic tests passed.pnpm run prettier:changed— passed, pinned repository formatter.pnpm run code-lint -- --ratchet --base origin/main— passed, 281 → 281 existing violations.pnpm run code-complexity:ci— passed, no new over-cap functions.pnpm run code-circular -- --ratchet --base origin/main --exceptions-file tools/scripts/code/circular-baseline-exception.json— passed, 210 → 210 cycles (11 baseline exceptions), run without overlapping own Git-fixture tests.pnpm run code-debt -- --gate --base origin/main— passed, no focused/new skipped tests.Remediation
Preserved current-main cancellation/scheduler and answer-quality fixes during extraction. Updated complete MCP operation inventory, replaced legacy KnowPro answer-generation fixtures with deterministic integrated-reader fixtures, isolated existing controlled View models from unrelated automatic discovery, and aligned transport timeout validation with the service's bounded 1–3,600,000ms contract. Complete Hub client testing also identified a malformed knowledge-response failure escaping into Questions; preparation now retains source progress and reports the failure locally.
Latest-head CI
Verified head
b7dcb1065b5f77fffbf6cf5f9be52dc5816ed89d: all required checks pass. All nine TypeScript OS/Node lanes, both .NET configurations, all three shell packaging lanes, formatting, repository policy, CodeQL, generated-document regeneration and external Linux/Windows smoke tests pass. The fork-only formatting check is intentionally skipped; no actionable failures or pending checks remain. No merge or auto-merge was requested.