Skip to content

Add automatic knowledge discovery, readiness checkpoints and integrated answering - #3226

Merged
Hillary Mutisya (hillary-mutisya) merged 3 commits into
mainfrom
dev/hillarym/memory-pr3-knowledge
Oct 26, 2026
Merged

Hillary Mutisya (hillary-mutisya) merged 3 commits into
mainfrom
dev/hillarym/memory-pr3-knowledge

Conversation

@hillary-mutisya

@hillary-mutisya Hillary Mutisya (hillary-mutisya) commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

PR3: automatic knowledge discovery, readiness checkpoints and integrated answering, based on main after #3224 and #3225.

  • Adds bounded corpus-level question proposal, utility/admission and routing with persisted receipts, fingerprints, existing-contract suppression, hourly call budgets and allowance-reserving repair. Existing corpora remain off until enabled; new corpora default to sourceObserved. Policy admission does not confirm answers or authorize tools.
  • Adds fixed-source/family readiness checkpoints, producer-complete bounded continuation and explicit partial/blocked/failed/superseded/cancelled states. Coordinates ingestion, maintenance, retry, invalidation, privacy removal and shutdown. Lazy curated-topic summaries do not require prose for readiness; complete curation coverage is still required.
  • Adds integrated answering over originals and eligible published Views: exact retained-source expansion, separate derived/user-assertion evidence, authority/review/freshness/conflict/scope/eligibility checks, original-source citations, evidence/request bounds, bounded follow-up retrieval/refinement and opt-in diagnostics.
  • Wires service/client/protocol/RPC/MCP and browser operation inventories, browser answering, Questions knowledge status/policy controls and source-plus-View answer rendering.
  • Adds deterministic qualification-harness checkpoint orchestration and metadata-only profiling fidelity tests.

Boundaries

Extracted feature commits and later scoped repairs from immutable integration source, reconciled against current main instead of replacing shared files with older versions. Preserves merged question inventories, answer-quality repairs and lazy topic behavior.

Excludes PR4's scoped graph APIs/projections/entity-event/hierarchy work, graph UI/RPC/MCP, generic Views/Inbox/navigation redesign and lazy read-projection optimizations. No PR4 branch dependency.

No live inference, pilot, replay, LongMemEval evaluation or performance qualification was run. The previous stopped pilot is not a completed qualification or scoring result.

Validation

Commands run from ts unless a package directory is specified:

  • pnpm run build — full workspace passed.
  • Memory service: pnpm run jest-esm --runInBand --testPathPattern='(knowledgeCoordinator|knowledgeDiscovery|knowledgeLifecycle|knowledgeAnswering|integratedAnswer|schemaViews|topicService|viewBuilds|viewDrafts|informationalWiki|viewSynthesisEvidence|wikiContribution)[.]spec[.]js' — 301 tests passed.
  • Memory service: pnpm run jest-esm --runInBand --testPathPattern='(answerKnowPro|fileMemoryService|markdownPersistence|maintenanceScheduler|topicGeneration|topicFamily|corpusIngestionIsolation)[.]spec[.]js' — 86 tests passed.
  • pnpm --filter @typeagent/memory-client test:local — 49 passed.
  • pnpm --filter @typeagent/memory-mcp-server test:local — 38 passed; aligned timeout/controlled-model fixtures additionally rechecked with focused knowledge/inventory tests.
  • Browser: pnpm run test:views:gateway — 102 passed; final timeout RPC test additionally rechecked.
  • Browser: pnpm run test:views:client -- --testPathPattern='memoryHub(KnowledgeStatus|Questions|Search)[.]test[.]ts' — 53 passed; pnpm run test:views:client — all 339 tests passed after adding malformed-status isolation.
  • node --test tools\memory-maintenance-qualification\longmemeval-runner.test.mjs tools\memory-maintenance-qualification\ingestion-profile.test.mjs — 43 deterministic tests passed.
  • pnpm run prettier:changed — passed, pinned repository formatter.
  • pnpm run code-lint -- --ratchet --base origin/main — passed, 281 → 281 existing violations.
  • pnpm run code-complexity:ci — passed, no new over-cap functions.
  • pnpm run code-circular -- --ratchet --base origin/main --exceptions-file tools/scripts/code/circular-baseline-exception.json — passed, 210 → 210 cycles (11 baseline exceptions), run without overlapping own Git-fixture tests.
  • pnpm run code-debt -- --gate --base origin/main — passed, no focused/new skipped tests.

Remediation

Preserved current-main cancellation/scheduler and answer-quality fixes during extraction. Updated complete MCP operation inventory, replaced legacy KnowPro answer-generation fixtures with deterministic integrated-reader fixtures, isolated existing controlled View models from unrelated automatic discovery, and aligned transport timeout validation with the service's bounded 1–3,600,000ms contract. Complete Hub client testing also identified a malformed knowledge-response failure escaping into Questions; preparation now retains source progress and reports the failure locally.

Latest-head CI

Verified head b7dcb1065b5f77fffbf6cf5f9be52dc5816ed89d: all required checks pass. All nine TypeScript OS/Node lanes, both .NET configurations, all three shell packaging lanes, formatting, repository policy, CodeQL, generated-document regeneration and external Linux/Windows smoke tests pass. The fork-only formatting check is intentionally skipped; no actionable failures or pending checks remain. No merge or auto-merge was requested.

Extract scoped discovery, readiness checkpoints, exact source-backed answering, protocol and Memory Hub wiring while preserving merged question and curation behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Preserve explicit nonready failures across transports, align the one-hour bounded timeout, and isolate pre-existing controlled View models from unrelated discovery calls.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Retain source progress and explicit preparation failures when a knowledge response cannot render; cover the complete Memory Hub client suite.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@hillary-mutisya
Hillary Mutisya (hillary-mutisya) merged commit 6ab40db into main Oct 26, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant