Skip to content

Fix accessibility bug 2492041 a11y role link buttons #3597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
navya9singh merged 2 commits into from
Jul 1, 2026
Merged

Fix accessibility bug 2492041 a11y role link buttons #3597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1d13f9
fix: add role=button to Back and Show Sample Code anchor elements on …
navya9singh Jun 29, 2026
46fffe6
fix: add role=button to Try TypeScript Now fluid button
navya9singh Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/typescriptlang-org/src/components/index/AboveTheFold.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ const Row = (props: { children: any, className?: string }) => <div className={[p
const Col = (props: { children: any, className?: string }) => <div className={[props.className, "col1"].join(" ")}>{props.children}</div>
const Col2 = (props: { children: any }) => <div className="col2">{props.children}</div>

const FluidButton = (props: { href?: string, onClick?: any, title: string, subtitle?: string, icon: JSX.Element, className?: string }) => (
<a className={"fluid-button " + props.className || ""} href={props.href} onClick={props.onClick}>
const FluidButton = (props: { href?: string, onClick?: any, title: string, subtitle?: string, icon: JSX.Element, className?: string, role?: string }) => (
<a className={"fluid-button " + props.className || ""} href={props.href} onClick={props.onClick} role={props.role}>
<div>
<div className="fluid-button-title">{props.title}</div>
<div className="fluid-button-subtitle">{props.subtitle}</div>
Expand Down Expand Up @@ -43,6 +43,7 @@ export const AboveTheFold = () => {
subtitle={i("index_2_cta_install_subtitle")}
href="/download"
onClick={onclick}
role="button"
icon={
<svg width="21" height="5" viewBox="0 0 21 5" fill="none" xmlns="http://www.w3.org/2000/svg">
<rect x="0.5" y="0.5" width="4" height="4" stroke="black" />
Expand Down Expand Up @@ -122,7 +123,7 @@ export const AboveTheFold = () => {
const Content = window.innerWidth < 600 ? CTAHeadlineMobile : CTAHeadlines
return (
<div className="cta">
<a className="transparent-button" onClick={() => setShowCTALinks(false)} href="#">
<a className="transparent-button" onClick={() => setShowCTALinks(false)} href="#" role="button">
<svg width="21" height="14" viewBox="0 0 21 14" fill="none" xmlns="http://www.w3.org/2000/svg">
<path d="M20.25 7.75L1.75 7.75M1.75 7.75L7.75 1.25M1.75 7.75L7.75 13.25" stroke="white" strokeWidth="2" />
</svg>
Expand Down
1 change: 1 addition & 0 deletions packages/typescriptlang-org/src/components/index/EditorExamples.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ export const EditorExamples = () => {
href="#"
onClick={next}
aria-label="Show code sample"
role="button"
>
<svg
width="11"
Expand Down
Loading