-
Notifications
You must be signed in to change notification settings - Fork 60
Emit AG-UI events for hosted MCP tool calls and results #1121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PratikDhanave (PratikDhanave)
wants to merge
2
commits into
microsoft:main
Choose a base branch
from
PratikDhanaveFork:fix/agui-mcp-tool-events
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MCP tool-call events lose the
parentMessageIdassociation that the siblingFunctionCallContentcase sets a few lines above (WithParentMessageID(messageID), with the comment "Associate the tool call with its assistant message ... Matches the Python host").Upstream, both
_emit_tool_call(regular function calls) and_emit_mcp_tool_call— the function this PR's own description cites as the Python source — call_track_tool_call_segment(flow, tool_call_id)and pass the result asparent_message_idtoToolCallStartEvent(python/packages/ag-ui/agent_framework_ag_ui/_run_common.py,_emit_mcp_tool_call~L1002-1008,_track_tool_call_segment~L574). Python does not special-case MCP calls to omit it.Because
toAgentMessages(hosting_convert.go) coalesces consecutive assistant messages by keying offToolCallStartEvent.parentMessageId(seeagui.go'spendingToolCall{MessageID: cmp.Or(deref(e.ParentMessageID), e.ToolCallID)}), an MCP tool call streamed withoutparentMessageIdwon't coalesce with the surrounding assistant message the way a regular function call does — risking the same "two consecutive single-tool-call assistant messages without intervening tool results" HTTP 400 theFunctionCallContentfix was meant to prevent, now specifically for hosted MCP tool calls.Suggested fix: pass
WithParentMessageID(messageID)(guarded onmessageID != "") toNewToolCallStartEventhere too, matching theFunctionCallContentcase and the Python_emit_mcp_tool_call/_track_tool_call_segmentbehavior.