Fix ResponseUpdate.String godoc: it has no messages - #1150
PratikDhanave (PratikDhanave) wants to merge 1 commit into
Conversation
ResponseUpdate.String iterates the update's own Contents; a ResponseUpdate has no messages. The "response messages" wording was copied from Response.String (which does iterate resp.Messages).
github-actions
Bot
added
area:agent
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
Documentation now matches the implementation, with no unresolved issues.
Review effort: Lite
Findings: None
What changed in this PR
Updates ResponseUpdate.String godoc to accurately describe the update’s contents.
Changes:
- Corrected the documentation in
agent/response.go.
| File | Description |
|---|---|
agent/response.go |
Corrected ResponseUpdate.String godoc. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Scope: internal-only (documentation comment only) Changed Go contract: None — this PR only corrects the godoc comment on Upstream evidence reviewed: Not applicable — no API or behavior changed, so no upstream .NET/Python comparison is needed. Result: out of scope for cross-repo parity review. This is a 1-line comment-only fix (+1/-1 in
|
ResponseUpdate.Stringranges overr.Contents(this single update's own content slice), but its comment says it returns "the concatenated text contents of the response messages." AResponseUpdatehas no messages — the wording was copied fromResponse.String, which genuinely iteratesresp.Messages. Comment-only fix.