Fix loop.Config.MaxIterations godoc: no exported DefaultMaxIterations - #1151
PratikDhanave (PratikDhanave) wants to merge 1 commit into
Conversation
The comment referenced DefaultMaxIterations, which does not exist; the only constant is the unexported defaultMaxIterations = 10. State the default value directly.
github-actions
Bot
added
area:agent
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The documentation-only change resolves the inaccurate symbol reference.
Review effort: Lite
Findings: None
What changed in this PR
Corrects the MaxIterations GoDoc to state the actual default value.
Changes:
- Replaces the nonexistent
DefaultMaxIterationsreference with 10 iterations.
| File | Description |
|---|---|
agent/harness/loop/loop.go |
Corrects MaxIterations documentation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Scope: internal-only (documentation/comment-only change) Changed Go contract: None. The change only edits a godoc comment on Upstream evidence reviewed: Not applicable — no exported API or observable behavior changed, so no upstream .NET/Python comparison is warranted. Result: out of scope. This is a comment-only correctness fix with no cross-repo parity implications.
|
The
MaxIterationscomment says "When nil, DefaultMaxIterations is used," but there is no exportedDefaultMaxIterationssymbol — the only constant is the unexporteddefaultMaxIterations = 10. State the default (10) directly. Comment-only fix.