Skip to content

Fix OnMessageDeliveryStarting godoc: hooks stop on first error #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PratikDhanave (PratikDhanave) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix OnMessageDeliveryStarting godoc: hooks stop on first error #1152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions workflow/executor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,8 +306,8 @@ func (e *Executor) OnCheckpointRestored(ctx *Context) error {
return nil
}

// OnMessageDeliveryStarting invokes all configured OnMessageDeliveryStarting
// hooks. Returns the first error from any hook.
// OnMessageDeliveryStarting invokes the configured OnMessageDeliveryStarting
// hooks in order, stopping at and returning the first hook error.
func (e *Executor) OnMessageDeliveryStarting(ctx *Context) error {
if e.OnMessageDeliveryStartingFunc != nil {
return e.OnMessageDeliveryStartingFunc(ctx)
Expand Down
Loading