Skip to content

Improve API consistency review workflow - #1172

Merged
Quim Muntal (qmuntal) merged 3 commits into
mainfrom
ci/improve-api-consistency-review
Sep 23, 2026
Merged

Quim Muntal (qmuntal) merged 3 commits into
mainfrom
ci/improve-api-consistency-review

Conversation

@qmuntal

Copy link
Copy Markdown
Member

Summary

Improve the API consistency review workflow based on recent execution history. Six dispatched reviews completed their analysis but failed label publication with No issue/PR number available.

  • Pass standard aw_context metadata from the fork dispatcher so safe-output handlers can resolve the PR without relying on model-supplied targets.
  • Skip test-only and example-verifier-only changes in both triggers, and include the PR number in run titles.
  • Add upstream locations for all eight providers and identify Microsoft.Extensions.AI as the primary .NET reference for the Go message model. Use complete repository URLs while retaining relative source paths.
  • Add a Markdown summary template and centralize outcome/label handling, including stale-approval cleanup and compact out-of-scope summaries.
  • Remove the obsolete CLI proxy workaround and use gh-aw's default MCP transport. Regenerate the workflow with gh-aw v0.88.7.

Validation

  • Workflow compilation passed with no warnings.
  • Offline regression checks passed for eight path-filter cases, the old missing-context reproduction, dispatched and native PR context, and run titles. Dispatch calls were mocked; context resolution used the pinned gh-aw helper.
  • Fork dispatcher lint passed. Generated workflow lint passed with narrow exclusions for the existing copilot-requests and concurrency.queue syntax compatibility issues.
  • git diff --check passed; editor diagnostics reported no errors.
  • No live workflow run was dispatched. Go tests were not run because the changes only affect workflow configuration and prompts.

@qmuntal
Quim Muntal (qmuntal) requested a review from a team as a code owner September 23, 2026 09:25
Copilot AI balanced review requested due to automatic review settings September 23, 2026 09:25
@github-actions github-actions Bot added area:github Changes files in the github area size:large At most 300 changed lines across at most 10 files labels Sep 23, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The otelprovider guidance includes an unrelated Python telemetry module that could misdirect parity reviews.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
What changed in this PR

Improves API consistency reviews by making fork dispatches reliable and expanding upstream guidance.

Changes:

  • Adds PR context, filtering, and descriptive run names.
  • Centralizes review outcomes and label handling.
  • Updates upstream references and regenerates the workflow.
File Description
.github/​workflows/​go-api-consistency-review.md Refines scope, references, and output policy.
.github/​workflows/​go-api-consistency-review.lock.yml Regenerates the executable workflow.
.github/​workflows/​go-api-consistency-review-forks.yml Passes PR context for fork dispatches.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/go-api-consistency-review.md Outdated
@github-actions github-actions Bot added the kind:ci Changes CI, build, or repository automation label Sep 23, 2026
@qmuntal
Quim Muntal (qmuntal) added this pull request to the merge queue Sep 23, 2026
Merged via the queue into main with commit f4eb860 Sep 23, 2026
21 checks passed
@qmuntal
Quim Muntal (qmuntal) deleted the ci/improve-api-consistency-review branch September 23, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:github Changes files in the github area kind:ci Changes CI, build, or repository automation size:large At most 300 changed lines across at most 10 files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants