Skip to content

[dotnet-code] Clarify workflow merger metadata collection #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Michelle Clayton (michelle-clayton-work) wants to merge 1 commit into from
Closed

[dotnet-code] Clarify workflow merger metadata collection #1177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 26 additions & 12 deletions workflow/agentworkflow/message_merger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,27 +44,21 @@ func (m *messageMerger) AddUpdate(update *agent.ResponseUpdate) {

func (m *messageMerger) ComputeMerged(primaryResponseID string, primaryAgentID string, primaryAgentName string) *agent.Response {
var messages []*message.Message
agentIDs := make(map[string]struct{})
finishReasons := make(map[string]struct{})
var additionalProperties map[string]any
var responses []*agent.Response

for _, responseID := range m.stateOrder {
state := m.states[responseID]
responses := state.computeResponses()
merged := mergeResponseList(responses)
responseList := state.computeResponses()
merged := mergeResponseList(responseList)
if merged == nil {
continue
}
if merged.AgentID != "" {
agentIDs[merged.AgentID] = struct{}{}
}
if merged.FinishReason != "" {
finishReasons[merged.FinishReason] = struct{}{}
}
additionalProperties = mergeProperties(additionalProperties, merged.AdditionalProperties)
responses = append(responses, merged)
messages = append(messages, messagesWithCreatedAt(merged)...)
}

agentIDs, finishReasons, additionalProperties := collectMergedResponseMetadata(responses)

messages = append(messages, m.danglingState.computeFlattened()...)
messages = foldIdentifierlessMessages(messages)
messages = cleanupMergedMessages(messages)
Expand All @@ -88,6 +82,26 @@ func (m *messageMerger) ComputeMerged(primaryResponseID string, primaryAgentID s
return response
}

func collectMergedResponseMetadata(responses []*agent.Response) (map[string]struct{}, map[string]struct{}, map[string]any) {
agentIDs := make(map[string]struct{})
finishReasons := make(map[string]struct{})
var additionalProperties map[string]any

for _, response := range responses {
if response == nil {
continue
}
if response.AgentID != "" {
agentIDs[response.AgentID] = struct{}{}
}
if response.FinishReason != "" {
finishReasons[response.FinishReason] = struct{}{}
}
additionalProperties = mergeProperties(additionalProperties, response.AdditionalProperties)
}
return agentIDs, finishReasons, additionalProperties
}

type collectedResponseMergeState struct {
allUpdates *messageMerger
terminalWorkflowOutput *messageMerger
Expand Down
Loading