Repository navigation
fix: add explicit utf-8 encoding to text-mode open() calls - #8311
Open
ZhengQiangZhang (LeonZhang778) wants to merge 1 commit into
Open
ZhengQiangZhang (LeonZhang778) wants to merge 1 commit into
ZhengQiangZhang (LeonZhang778) wants to merge 1 commit into
Conversation
Fixes microsoft#5566 On non-ASCII / non-English locales (e.g. Windows cp950), text-mode open() calls without an explicit encoding raise UnicodeDecodeError when the file contains non-ASCII bytes. The reported playwright_controller.py case was already fixed; this change addresses the remaining similar open() calls across the Python packages by passing encoding="utf-8".
Author
|
@microsoft-github-policy-service agree |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5566
On non-ASCII / non-English locales (e.g. Windows cp950), text-mode open() calls without an explicit encoding raise UnicodeDecodeError when the file contains non-ASCII bytes. The reported playwright_controller.py case was already fixed; this change addresses the remaining similar open() calls across the Python packages by passing encoding="utf-8".
Why are these changes needed?
Related issue number
Checks