Repository navigation
Conversation
Author
|
@microsoft-github-policy-service agree |
Author
|
@microsoft-github-policy-service terminate |
Author
|
@microsoft-github-policy-service agree |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
A tool decorated with
functools.wrapscan raiseNameErrorduring registration when its string annotations refer to names in the original function's module.inspect.signaturefollows the wrapped function, but passing the wrapper's globals totyping.get_type_hintsresolves those annotations in the wrong namespace.Let
get_type_hintsselect the defining namespace in both signature and return-type resolution. The regression tests cover undecorated functions, one wrapper, nested wrappers, schema generation, and an actualFunctionTool.run_jsoncall with a datetime argument.Validation:
Related issue number
Related to #8302, which addresses globals for partial functions. This change also covers ordinary and nested wrappers across modules, including return-type resolution.
Checks