Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
FunctionToolaccepts annotated functions with positional-only parameters and generates their schemas, but calling them fails because every argument is passed as a keyword. For example,def scale(value: int, /, *, factor: int = 2)validates{"value": 3}and then raisesTypeErrorinstead of returning6.Bind positional-only values in signature order and pass the remaining values as keywords. Cancellation-token injection follows the same binding rules; synchronous executor cancellation keeps its existing behavior.
Eight new regression cases cover sync/async functions, defaults, mixed keyword-only parameters,
partial, and positional-only cancellation tokens. All eight fail on the original implementation. The complete core suite passes with the fix: 234 passed. Scoped Ruff, mypy and Pyright checks and the core wheel build also pass. Validation used Windows and Python 3.12.2 with the relevant dependencies aligned touv.lock; .NET checks were not run.Related issue number
Fixes #8319
Checks