Repository navigation
fix: reject checkpoint resume for a different task ID - #96
Open
alexruidan (xLagerFeuer) wants to merge 1 commit into
Open
alexruidan (xLagerFeuer) wants to merge 1 commit into
alexruidan (xLagerFeuer) wants to merge 1 commit into
Conversation
|
alexruidan (@xLagerFeuer) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
RunContext.create(..., task=..., output_dir=...)resumes an existingtask.jsonwithout comparing its task ID with the caller's requested task. Reusing the same directory for a different task can silently attribute one task's saved checkpoint to another.Change
task_iddiffers from the requested task ID, before changing the run context.Verification
microsoft/fara@a675d6d61c41c47ae87bacefeab22caad18e3e84: test-only patch 2 passed, 1 failed (mismatched task accepted).5b2499026322e25ac6d6182778914171a85f56b6: 3 passed, 0 failed runningPYTHONPATH=src pytest -q tests/test_run_context_resume_identity.pywith Python 3.12 and Pydantic v2.mainSHA, direct public fork and MIT license verified. No legal contributor-person DCO or CLA claim.Provenance and scope
This is a bounded native checkpoint correctness fix informed by the current OpenSiro assessment, independently reproduced against first-party code, not proof of VSM grade improvement or measured user benefit. Native evidence: OpenSiro packet #249 and executor #250.
AI-assisted contribution disclosure
VSM assessment: Current record · Snapshot used for this PR
Assessment date: 2026-10-17 (
reviewed_at) · Assessed source revision:a675d6d61c41c47ae87bacefeab22caad18e3e84This PR was prepared and published through the OpenSiro Upstream Contributions AI-agent workflow under the owner's standing publication mandate, without a separate human approval of this PR. Technical analysis, code changes and reported checks were agent-driven; no independent human code review or correctness certification is claimed. Agent-generated changes may be incomplete or incorrect. Please review the diff and reproducible evidence independently.
The linked VSM assessment describes the assessed source revision on the stated date, not a guarantee about this PR or later upstream code. Maintainers and their agents can compare the current record with the snapshot and reassess if the source or evidence has changed. The external maintainers alone decide whether to accept or merge this contribution.