Skip to content

feat(power-bi): add subscription to unattached disks report - #2337

Open
UJJWAL RAJ (iUjjwalRaj) wants to merge 1 commit into
microsoft:devfrom
iUjjwalRaj:iUjjwalRaj/pbi-unattached-disks-subscription
Open

UJJWAL RAJ (iUjjwalRaj) wants to merge 1 commit into
microsoft:devfrom
iUjjwalRaj:iUjjwalRaj/pbi-unattached-disks-subscription

Conversation

@iUjjwalRaj

Copy link
Copy Markdown

🛠️ Description

  • Added the Subscription column (Subscriptions.name) to the "Compute disks" table visual on the "Unattached disks" page.
  • Applied the exact same visual definition updates to both KQL (src/power-bi/kql/WorkloadOptimization.Report/report.json) and Storage (src/power-bi/storage/WorkloadOptimization.Report/report.json) Workload Optimization reports.
  • Added the required changelog entry in docs-mslearn/toolkit/changelog.md under the active unreleased section.

Local Validation

  • Local Python JSON parsing and structural assertions passed (verified valid JSON syntax, single Subscriptions From source, single Subscriptions.name Select property and projection positioned immediately after Disks (2).resourceGroup, displayName "Subscription", and 100% parity across KQL and Storage report definitions).
  • git diff --check passed cleanly with no whitespace or formatting errors.
  • Pester unit/lint test suite could not be run locally because PowerShell (pwsh) is not installed in this macOS environment.

Fixes #2201

📷 Screenshots

Not applicable (Power BI report schema updated directly in report.json).

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

📦 Deploy to test?

  • Hubs + ADX (managed)
  • Hubs + Fabric (manual) — URI:
  • Hubs (manual)
  • Hubs (no data)
  • Workbooks
  • Alerts

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Public docs in docs-mslearn (required for dev)
  • ✅ Internal dev docs in docs-wiki (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

Copilot AI balanced review requested due to automatic review settings October 5, 2026 09:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@microsoft-github-policy-service microsoft-github-policy-service Bot added the Micro PR 🔬 Very small PR that should be especially easy for newcomers label Oct 5, 2026
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Needs: Review 👀 PR that is ready to be reviewed label Oct 5, 2026
@iUjjwalRaj

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Micro PR 🔬 Very small PR that should be especially easy for newcomers Needs: Review 👀 PR that is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Power BI] Workload optimization report (Unattached disks - add subscription)

4 participants