Repository navigation
feat(finops-hub): add Azure Data Explorer encryption options - #2338
Open
Chaithanya Nallamothu (Chaithanyanallamothu) wants to merge 2 commits into
Conversation
microsoft-github-policy-service
Bot
added
the
Needs: Review 👀
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds configurable Azure Data Explorer (ADX) disk and double encryption options to the FinOps Hub Bicep templates and wires them through module boundaries to the ADX (Kusto) cluster resource.
Changes:
- Introduced
enableAdxDiskEncryptionandenableAdxDoubleEncryptionparameters (defaultfalse) inmain.bicep,modules/hub.bicep, andAnalytics/app.bicep. - Applied both flags to the
Microsoft.Kusto/clustersresource properties. - Added a test deployment scenario enabling both encryption options and updated the toolkit changelog.
| File | Description |
|---|---|
| src/templates/finops-hub/test/main.test.bicep | Adds a second test module deployment enabling both ADX encryption flags. |
| src/templates/finops-hub/modules/hub.bicep | Adds params and forwards them into the Analytics module. |
| src/templates/finops-hub/modules/Microsoft.FinOpsHubs/Analytics/app.bicep | Adds params and sets Kusto cluster encryption properties based on them. |
| src/templates/finops-hub/main.bicep | Adds top-level params and passes them to the hub module. |
| docs-mslearn/toolkit/changelog.md | Notes the new ADX encryption options in the changelog. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
314
to
317
| enableStreamingIngest: true | ||
| enableDiskEncryption: enableAdxDiskEncryption | ||
| enableDoubleEncryption: enableAdxDoubleEncryption | ||
| enableAutoStop: false |
Copilot started reviewing on behalf of
Chaithanya Nallamothu (Chaithanyanallamothu)
October 5, 2026 21:46
View session
Author
|
@microsoft-github-policy-service agree |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Adds Azure Data Explorer disk and double encryption options to FinOps Hub.
enableAdxDiskEncryptionandenableAdxDoubleEncryption, both disabled by default.Fixes #2196
📷 Screenshots
Not applicable. This change only updates the FinOps Hub deployment templates.
📋 Checklist
🔬 How did you test this change?
Validated the updated Bicep templates locally and successfully ran
Build-Toolkit finops-hub.📦 Deploy to test?
🙋♀️ Do any of the following that apply?
📑 Did you update
docs/changelog.md?📖 Did you update documentation?