Update to ort 1.3.0.0 and genai to 0.16.0 - #1102
Merged
Baiju Meswani (baijumeswani) merged 5 commits intoSep 14, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Copilot started reviewing on behalf of
Baiju Meswani (baijumeswani)
September 13, 2026 08:30
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unconditional Engine compilation can break older or local GenAI configurations; retain capability gating or add minimum-version validation.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates the SDK to ONNX Runtime 1.30.0 and GenAI 0.16.0, refreshing Engine, CUDA, and CI configuration.
Changes:
- Synchronizes dependency pins across SDKs, packaging, and pipelines.
- Enables Engine sources and tests unconditionally.
- Refreshes CUDA EP manifests, hashes, and Engine CI settings.
File summaries
| File | Summary |
|---|---|
sdk_v2/rust/deps_versions.json |
Synchronizes Rust dependency pins. |
sdk_v2/js/test/install-native.test.ts |
Updates installer version expectations. |
sdk_v2/deps_versions.json |
Updates canonical dependency pins. |
sdk_v2/cpp/test/internal_api/cuda_ep_bootstrapper_test.cc |
Refreshes CUDA manifest expectations. |
sdk_v2/cpp/test/CMakeLists.txt |
Includes Engine tests unconditionally. |
sdk_v2/cpp/src/inferencing/generative/genai_model_instance.h |
Removes conditional Engine declarations. |
sdk_v2/cpp/src/inferencing/generative/genai_model_instance.cc |
Enables unconditional Engine initialization. |
sdk_v2/cpp/src/inferencing/generative/chat/chat_session.cc |
Removes Engine availability guards. |
sdk_v2/cpp/src/ep_detection/cuda_ep_manifest.cc |
Updates CUDA bundle metadata and hashes. |
sdk_v2/cpp/CMakeLists.txt |
Builds Engine sources unconditionally; older or local GenAI overrides may fail to compile. |
.pipelines/v2/templates/stages-test-engine.yml |
Updates Engine CI dependencies. |
.pipelines/v2/templates/stages-sdk-v2.yml |
Passes the GenAI version to Engine tests. |
.pipelines/v2/sdk_v2-pipeline-plan.md |
Documents updated dependency versions. |
.pipelines/foundry-local-packaging.yml |
Updates packaging dependency variables. |
.github/instructions/cpp-ci-test-policy.instructions.md |
Updates Engine CI policy. |
Review details
- Files reviewed: 15/15 changed files
- Comments generated: 1
- Review effort level: Lite (auto)
Note
Copilot is running an experiment and ran this review at Lite.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Baiju Meswani (baijumeswani)
added this pull request to stack #1106
September 14, 2026 01:00
bmehta001
previously approved these changes
Sep 14, 2026
Baiju Meswani (baijumeswani)
dismissed
bmehta001’s stale review
via
September 14, 2026 16:38
57d1760
bmehta001
approved these changes
Sep 14, 2026
Baiju Meswani (baijumeswani)
deleted the
baijumeswani/update-ort-1.30-genai-0.16
branch
September 14, 2026 18:12
Baiju Meswani (baijumeswani)
added a commit
that referenced
this pull request
Sep 14, 2026
## Summary - treat `temperature: 1` as neutral when `do_sample` is omitted - keep the model package default authoritative - preserve existing behavior for non-neutral temperatures and explicit `do_sample` values ## Why OpenAI-compatible coding clients such as GitHub Copilot CLI send `temperature: 1` even when they are not requesting a sampling-policy override. Foundry previously translated every positive temperature into `do_sample=true`. That replaced the model package default and disabled DFlash2 drafting for packages whose default is `do_sample=false`. ORT GenAI already owns speculative-decoding eligibility: greedy turns may draft, while sampled turns run target-only. Foundry therefore does not need dflash2-specific detection, rejection logic, public controls, or test-only Engine statistics APIs. ## Behavior - omitted `do_sample`, omitted temperature: preserve all model defaults - omitted `do_sample`, `temperature: 1`: forward the neutral temperature and preserve the model default - omitted `do_sample`, non-neutral positive temperature: continue resolving to `do_sample=true` - explicit `do_sample=true`: remains explicit, including with `temperature: 1` ## Validation - focused `SamplingPlanTest.*` suite passes - real dflash2 release qualification confirmed that default, explicit greedy, and neutral-temperature turns draft - sampled turns complete through ORT GenAI target-only with zero draft activity - integrated Toolkit typed/reverse-result gate passes - stock GHCP coding gate proceeds with the package-owned greedy default and speculative decoding enabled Stacked on #1102 for ORT 1.30.0 and ORT GenAI 0.16.0. --------- Copilot-Session: 6883972e-cc0b-4076-a3a5-86106e7a1133
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.