[Squash On Rebase] RustPackageHelper.py: Update __set_members to avoid duplicates - #1916
Merged
Aaron (apop5) merged 1 commit intoSep 16, 2026
Conversation
Contributor
Author
|
release/202608 targeted change for #1915 |
Contributor
❌ QEMU Validation FailedSource Dependencies
Results
Workflow run: https://github.com/microsoft/mu_basecore/actions/runs/35136187075 This comment was automatically generated by the Mu QEMU PR Validation workflow. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/202608 #1916 +/- ##
=================================================
Coverage ? 1.70%
=================================================
Files ? 1674
Lines ? 417227
Branches ? 0
=================================================
Hits ? 7121
Misses ? 410106
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Aaron (apop5)
approved these changes
Sep 16, 2026
Antaeus Kleinert-Strand (antklein)
force-pushed
the
rust_package_helper_members_2608
branch
from
September 16, 2026 17:04
60ca275 to
51d5175
Compare
Deduplicate crates listed as both workspace members and path dependencies. Add tests covering duplicate paths, dependency filtering, and empty workspaces.
Antaeus Kleinert-Strand (antklein)
force-pushed
the
rust_package_helper_members_2608
branch
from
September 16, 2026 18:36
51d5175 to
01fe425
Compare
Joey Vagedes (Javagedes)
approved these changes
Sep 16, 2026
Antaeus Kleinert-Strand (antklein)
deleted the
rust_package_helper_members_2608
branch
September 16, 2026 20:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
RustPackageHelperto deduplicate Cargo workspace members by path before constructingRustPackageobjects.__set_membersfunction.type(...) != strcomparison withisinstance()when identifying path-based workspace dependencies.Some local crates are declared both as Cargo workspace members and as path-based workspace dependencies. The previous implementation placed
RustPackageinstances in a set, butRustPackagedoes not define value-based equality or hashing. Separate instances representing the same path were therefore retained as distinct entries.Collecting
Pathobjects in the set provides value-based deduplication and ensures each workspace package is tested once.How This Was Tested
Ran the Rust host-based unit test runner through
stuart_ci_build.Verified that each crate appears only once in the generated Cargo coverage command.
All unit tests are passing.
Integration Instructions
N/A