[CHERRY-PICK] Bug fix standalonemm core and PiSmmCore - #1920
Open
Khalid Ali (khaliid2040) wants to merge 3 commits into
Open
Khalid Ali (khaliid2040) wants to merge 3 commits into
Khalid Ali (khaliid2040) wants to merge 3 commits into
Conversation
… hob The second call to CreateMmFoundationHobList () expects the address of the beginning of the platform hob list in the third parameter. However it has being given the beginning of the HobList which is PHIT. This causes later wrong address calculations which in turns puts MM core in infinite loop, because the IPL passed hob without EFI_HOB_TYPE_END_OF_HOB_LIST. Signed-off-by: Khalid Ali <khaliidcaliy@gmail.com> (cherry picked from commit 962c1f2)
…check Fixes: #11764 Currently, mMmiManageCallingDepth is incremented always whether MMI handler is present or not. However get decremented only when MMI handler is found. This causes mMmiManageCallingDepth to grow infinitely as long as MMI handler isn't present. Increment mMmiManageCallingDepth only when MMI handler presence is confirmed. Signed-off-by: Khalid Ali <khaliidcaliy@gmail.com> (cherry picked from commit 05cec0b)
…sence check Fixes: #11764 Currently, mSmiManageCallingDepth is incremented always whether SMI handler is present or not. However get decremented only when SMI handler is found. This causes mSmiManageCallingDepth to grow infinitely as long as SMI handler isn't present. Increment mSmiManageCallingDepth only when SMI handler presence is confirmed. Signed-off-by: Khalid Ali <khaliidcaliy@gmail.com> (cherry picked from commit bd8667a)
Contributor
❌ QEMU Validation FailedSource Dependencies
Results
Workflow run: https://github.com/microsoft/mu_basecore/actions/runs/35104428873 This comment was automatically generated by the Mu QEMU PR Validation workflow. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/202511 #1920 +/- ##
=================================================
Coverage ? 1.63%
=================================================
Files ? 667
Lines ? 238547
Branches ? 550
=================================================
Hits ? 3893
Misses ? 234630
Partials ? 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Oliver Smith-Denny (os-d)
approved these changes
Sep 16, 2026
Oliver Smith-Denny (os-d)
requested review from
Aaron (apop5),
kuqin12 and
Michael Kubacki (makubacki)
September 16, 2026 13:41
Aaron (apop5)
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This patches fix bugs in StandaloneMm core and PiSmmCore:
Each patch is described in detail in the respective commit.
How This Was Tested
All these are merged in EDK2 master and have been tested on OVMF.
Integration Instructions
N/A