Repository navigation
Define the base_url fallback fixture as a class method - #342
Closed
Aditya Nikam (adityaanikam) wants to merge 1 commit into
Closed
Aditya Nikam (adityaanikam) wants to merge 1 commit into
Aditya Nikam (adityaanikam) wants to merge 1 commit into
Conversation
Pavel Feldman (pavelfeldman)
approved these changes
Nov 1, 2026
Member
|
Oh, i did not the the bots - looks flawed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #341
With pytest 9.2 and no pytest-base-url, the
base_urlfallback fixture raisedPytestRemovedIn10Warning, because it was a session-scoped fixture defined as an instance method. It is now a class method, as the warning recommends, in bothpytest-playwrightandpytest-playwright-asyncio.Added a test for each package that runs with
-W error::pytest.PytestDeprecationWarningand fails without the change. I checked the fix on pytest 7.0.0, 7.4.4, 8.4.2, 9.1.1 and 9.2.0.