Skip to content

Pin llvm - #122

Merged
Khang (nnmkhang) merged 1 commit into
mainfrom
user/khangnguyen/pin-bindgen-llvm
Sep 11, 2026
Merged

Khang (nnmkhang) merged 1 commit into
mainfrom
user/khangnguyen/pin-bindgen-llvm

Conversation

@nnmkhang

@nnmkhang Khang (nnmkhang) commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Description of Changes:

Pinning the LLVM version for binding generation since changes to the underlying CI images can conflict with the LLVM version. This causes issues with bindings and testing.

Breaking Changes if any:

None

✅ Admin Checklist

  • PR targets the active release/X.Y.Z branch.
  • Review the PR description and ensure all necessary details are included.
  • Update/add unit tests for changed code.
  • Update/add documentation for new or changed APIs.
  • Run cargo test --all-features on Windows and WSL.

Check the guidelines in CONTRIBUTING.md for more info.

@nnmkhang Khang (nnmkhang) changed the title pin llvm Pin llvm Sep 10, 2026
@nnmkhang
Khang (nnmkhang) marked this pull request as ready for review September 10, 2026 18:40

@MS-megliu MS-megliu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed PR #122. The LLVM/libclang pinning is correctly applied across all four bindgen targets. The unrelated CodeQL C/C++ autobuild failure is not a blocker for this change.

@nnmkhang
Khang (nnmkhang) merged commit 4218d7c into main Sep 11, 2026
19 of 20 checks passed
@nnmkhang
Khang (nnmkhang) deleted the user/khangnguyen/pin-bindgen-llvm branch September 11, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants