Skip to content

Python: fix(redis): pass collection prefix as a list - #14012

Open
Mukunda Rao Katta (MukundaKatta) wants to merge 2 commits into
microsoft:mainfrom
MukundaKatta:codex/semantic-kernel-redis-prefix
Open

Mukunda Rao Katta (MukundaKatta) wants to merge 2 commits into
microsoft:mainfrom
MukundaKatta:codex/semantic-kernel-redis-prefix

Conversation

@MukundaKatta

Copy link
Copy Markdown

No description provided.

@moonbox3 Evan Mattson (moonbox3) added the python Pull requests for the Python Semantic Kernel label May 15, 2026
@github-actions github-actions Bot changed the title fix(redis): pass collection prefix as a list Python: fix(redis): pass collection prefix as a list May 15, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes Redis search index creation by passing the IndexDefinition.prefix as a list (instead of a string), matching the expected Redis client API and preventing incorrect prefix handling.

Changes:

  • Update Redis connector index creation to pass prefix=[f"{collection_name}:"] to IndexDefinition.
  • Update the existing unit test that creates an IndexDefinition manually to use a list prefix.
  • Add a unit test asserting ensure_collection_exists() constructs IndexDefinition with a single-item prefix list for both HASH and JSON collections.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
python/semantic_kernel/connectors/redis.py Passes collection prefix to IndexDefinition as a list during index creation.
python/tests/unit/connectors/memory/test_redis_store.py Updates manual index-definition test and adds coverage ensuring list-prefix behavior for both collection types.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review finding (blocking): The new test constructs IndexType with invalid values

IndexType(expected_index_type) raises before the assertion runs: redis-py's supported IndexType enum uses members such as IndexType.HASH and IndexType.JSON, not the strings "hash" and "json". Please parametrize with the enum members directly so the added test actually validates the collection-prefix change.

This branch had an error being deployed

1 failed deployment
github-app-auth — 275cd6ae Deployed Sep 28, 2026 by eavanvalkenburg via add_label #29095
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Pull requests for the Python Semantic Kernel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants