Skip to content

fix: ChatHistory: preserve empty tool results with tool_call_id #14480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Wu Shuwen (dajiaohuang) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: ChatHistory: preserve empty tool results with tool_call_id #14480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/semantic_kernel/contents/chat_history.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ def _prepare_for_add(
"""Prepare a message to be added to the history."""
kwargs["role"] = role

if role == AuthorRole.TOOL and content and not items:
if role == AuthorRole.TOOL and content is not None and not items:
tool_call_id = kwargs.pop("tool_call_id", None)
function_name = kwargs.pop("function_name", "unknown")
function_result_content = FunctionResultContent(
Expand Down
Loading