Skip to content

Python: Clarify HttpPlugin defaults - #14495

Merged
Eduard van Valkenburg (eavanvalkenburg) merged 2 commits into
microsoft:mainfrom
eavanvalkenburg:incident-mitigation
Oct 6, 2026
Merged

Eduard van Valkenburg (eavanvalkenburg) merged 2 commits into
microsoft:mainfrom
eavanvalkenburg:incident-mitigation

Conversation

@eavanvalkenburg

@eavanvalkenburg Eduard van Valkenburg (eavanvalkenburg) commented Sep 28, 2026 •

Copy link
Copy Markdown
Member

Motivation and Context

Preserve established behavior while making the default configuration more visible to users.

Description

  • Preserve established default behavior.
  • Add a targeted configuration warning.
  • Keep explicit validation behavior unchanged and add focused tests.

Contribution Checklist

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The default HTTP and redirect behavior is a security-sensitive change requiring an explicit decision or retention of deny-by-default behavior.

Review effort: Lite
Findings: 1 High severity

Open (1)
What changed in this PR

Clarifies Python HttpPlugin defaults by changing behavior when no domain allow list is configured, adding a warning, and expanding tests.

Changes:

  • Updates default URL validation and redirect handling.
  • Adds a configuration warning for missing allowed_domains.
  • Adds focused coverage for defaults, warnings, and redirects.
File Summary
python/​tests/​unit/​core_plugins/​test_http_plugin.py Adds tests for default behavior, warnings, requests, and redirects.
python/​semantic_kernel/​core_plugins/​http_plugin.py Updates default validation, redirect behavior, documentation, and warning logic.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread python/semantic_kernel/core_plugins/http_plugin.py Outdated
@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
core_plugins
   http_plugin.py760100% 
TOTAL29045559580% 

Python Unit Test Overview

Tests Skipped Failures Errors Time
4122 22 💤 0 ❌ 0 🔥 2m 13s ⏱️

Merged via the queue into microsoft:main with commit d523438 Oct 6, 2026
33 checks passed
@eavanvalkenburg
Eduard van Valkenburg (eavanvalkenburg) deleted the incident-mitigation branch October 6, 2026 08:17

This branch was previously deployed

1 inactive deployment
github-app-auth — e130fbb9 Deployed Sep 30, 2026 by eavanvalkenburg via add_label #29175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Pull requests for the Python Semantic Kernel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants