Repository navigation
Python: Clarify HttpPlugin defaults - #14495
Merged
Eduard van Valkenburg (eavanvalkenburg) merged 2 commits intoOct 6, 2026
Merged
Eduard van Valkenburg (eavanvalkenburg) merged 2 commits into
Eduard van Valkenburg (eavanvalkenburg) merged 2 commits into
Conversation
Eduard van Valkenburg (eavanvalkenburg)
requested a review
from a team
as a code owner
September 28, 2026 12:05
Eduard van Valkenburg (eavanvalkenburg)
had a problem deploying
to
github-app-auth
September 28, 2026 12:05 — with
GitHub Actions
Failure
Eduard van Valkenburg (eavanvalkenburg)
had a problem deploying
to
github-app-auth
September 28, 2026 12:05 — with
GitHub Actions
Failure
Copilot started reviewing on behalf of
Eduard van Valkenburg (eavanvalkenburg)
September 28, 2026 12:05
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The default HTTP and redirect behavior is a security-sensitive change requiring an explicit decision or retention of deny-by-default behavior.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Clarifies Python HttpPlugin defaults by changing behavior when no domain allow list is configured, adding a warning, and expanding tests.
Changes:
- Updates default URL validation and redirect handling.
- Adds a configuration warning for missing
allowed_domains. - Adds focused coverage for defaults, warnings, and redirects.
| File | Summary |
|---|---|
python/tests/unit/core_plugins/test_http_plugin.py |
Adds tests for default behavior, warnings, requests, and redirects. |
python/semantic_kernel/core_plugins/http_plugin.py |
Updates default validation, redirect behavior, documentation, and warning logic. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Python Test Coverage Report •
Python Unit Test Overview
|
||||||||||||||||||||||||||||||
Eduard van Valkenburg (eavanvalkenburg)
had a problem deploying
to
github-app-auth
September 28, 2026 12:21 — with
GitHub Actions
Failure
Eduard van Valkenburg (eavanvalkenburg)
had a problem deploying
to
github-app-auth
September 28, 2026 13:54 — with
GitHub Actions
Failure
Eduard van Valkenburg (eavanvalkenburg)
had a problem deploying
to
github-app-auth
September 28, 2026 14:10 — with
GitHub Actions
Failure
Eduard van Valkenburg (eavanvalkenburg)
force-pushed
the
incident-mitigation
branch
from
September 30, 2026 08:57
2e390cc to
e130fbb
Compare
Eduard van Valkenburg (eavanvalkenburg)
temporarily deployed
to
github-app-auth
September 30, 2026 08:57 — with
GitHub Actions
Inactive
SergeyMenshykh
approved these changes
Sep 30, 2026
Jose Alvarez (jpalvarezl)
approved these changes
Oct 6, 2026
Eduard van Valkenburg (eavanvalkenburg)
deleted the
incident-mitigation
branch
October 6, 2026 08:17
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation and Context
Preserve established behavior while making the default configuration more visible to users.
Description
Contribution Checklist