Python: Fix postgres filter bug by westey-m · Pull Request #14497 · microsoft/semantic-kernel

westey (westey-m) · 2026-09-28T14:52:57Z

Motivation and Context

Description

Improve PostgreSQL query construction for search filters.
Expand unit and integration coverage for filtered searches.
Clarify supported filter input in the connector documentation.

Contribution Checklist

The code builds clean without any errors or warnings
The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
All unit tests pass, and I have added new tests where possible
I didn't break anyone 😄

Copilot

Copilot review overview

🟡 Changes recommended

Fix the syntax error and correctly translate None comparisons to IS NULL/IS NOT NULL.

Review effort: Lite
Findings: 1 · 1

Open (2)

Conditional for-loop expression causes SyntaxError · New
None comparisons generate incorrect SQL NULL predicates · New

What changed in this PR

This PR improves PostgreSQL filter construction, expands test coverage, and documents supported filter syntax.

Changes:

Parameterizes filter values.
Adds unit and integration coverage.
Documents supported filter inputs.

File	Summary
`python/tests/unit/connectors/memory/test_postgres_store.py`	Reviewed expanded filter parsing and query tests.
`python/tests/integration/memory/postgres/test_postgres_int.py`	Reviewed filtered-search integration coverage.
`python/semantic_kernel/connectors/postgres.py`	Found an import-blocking syntax error and incorrect `None` comparison SQL semantics.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

github-actions · 2026-09-28T16:13:24Z

Python Test Coverage Report •

File	Stmts	Miss	Cover	Missing
connectors
postgres.py	381	39	89%	139, 157, 184, 297–298, 388, 394–396, 401–402, 404–405, 412, 434, 490, 492, 494, 511, 523, 573, 582, 632, 652, 672, 677, 683, 695, 725, 729, 731, 753, 780, 785, 939, 943, 970–972
TOTAL	29063	5496	81%

Python Unit Test Overview

Tests	Skipped	Failures	Errors	Time
4241	22 💤	0 ❌	0 🔥	2m 12s ⏱️

…4313) Postgres search filters must produce SQL predicates with their values passed separately as ordered parameters. Extend the search execution tests to cover callable filters, single-item and empty lists, and mixed string/callable lists, including OR grouping, across all five supported distance functions and both result-consumption paths. The parameterized connector implementation from microsoft#14497 is preserved. The diff against main is limited to test coverage and adds 30 cases. Related to microsoft#14311. Validation on Python 3.12: - Postgres connector unit tests: 127 passed. - Shared data/vector unit tests: 76 passed. - Repository pre-commit checks for the Postgres connector and test file: passed, including Ruff, formatting, Python syntax, pyupgrade, and Bandit. The tests inspect the SQL and ordered parameters passed to the mocked Postgres cursor; no live database is required. Co-authored-by: Eduard van Valkenburg <eavanvalkenburg@users.noreply.github.com>

Fix postgres filter bug

c3ecd9f

Copilot AI lite review requested due to automatic review settings September 28, 2026 14:52

westey (westey-m) requested a review from a team as a code owner September 28, 2026 14:52

westey (westey-m) had a problem deploying to github-app-auth September 28, 2026 14:53 — with GitHub Actions Failure

Copilot started reviewing on behalf of westey (westey-m) September 28, 2026 14:53

View session

Copilot AI reviewed Sep 28, 2026

View reviewed changes

Comment thread python/semantic_kernel/connectors/postgres.py

Comment thread python/semantic_kernel/connectors/postgres.py

Eduard van Valkenburg (eavanvalkenburg) previously approved these changes Sep 28, 2026

View reviewed changes

Address PR comments

1f8b78c

westey (westey-m) had a problem deploying to github-app-auth September 28, 2026 16:10 — with GitHub Actions Failure

westey (westey-m) enabled auto-merge September 28, 2026 16:25

westey (westey-m) dismissed Eduard van Valkenburg (eavanvalkenburg)’s stale review via 1f8b78c September 29, 2026 09:42

Eduard van Valkenburg (eavanvalkenburg) approved these changes Sep 29, 2026

View reviewed changes

Merge branch 'main' into python-postgres-filter-bugfixes

09ec5b7

westey (westey-m) temporarily deployed to github-app-auth September 29, 2026 14:49 — with GitHub Actions Inactive

semantic-kernel-automation Bot added the python Pull requests for the Python Semantic Kernel label Sep 29, 2026

Eduard van Valkenburg (eavanvalkenburg) approved these changes Sep 29, 2026

View reviewed changes

Eduard van Valkenburg (eavanvalkenburg) approved these changes Sep 30, 2026

View reviewed changes

SergeyMenshykh approved these changes Sep 30, 2026

View reviewed changes

westey (westey-m) added this pull request to the merge queue Sep 30, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 30, 2026

westey (westey-m) added this pull request to the merge queue Sep 30, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 30, 2026

Merge branch 'main' into python-postgres-filter-bugfixes

acb3c6e

westey (westey-m) enabled auto-merge September 30, 2026 17:54

westey (westey-m) temporarily deployed to github-app-auth September 30, 2026 17:54 — with GitHub Actions Inactive

Eduard van Valkenburg (eavanvalkenburg) approved these changes Oct 1, 2026

View reviewed changes

Merge branch 'main' into python-postgres-filter-bugfixes

81f8edb

westey (westey-m) temporarily deployed to github-app-auth October 1, 2026 10:34 — with GitHub Actions Inactive