Repository navigation
Restrict DevFlow PR reviews to internal contributors - #14503
Merged
SergeyMenshykh merged 2 commits intoSep 29, 2026
Merged
SergeyMenshykh merged 2 commits into
SergeyMenshykh merged 2 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
SergeyMenshykh
had a problem deploying
to
github-app-auth
September 29, 2026 13:28 — with
GitHub Actions
Failure
SergeyMenshykh
had a problem deploying
to
github-app-auth
September 29, 2026 13:28 — with
GitHub Actions
Failure
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The security-sensitive gate still has excess permissions, and its live team and App configuration needs human validation.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
This PR limits DevFlow pull request reviews to internal contributors while keeping the existing relevance check and review steps.
Changes:
- Split review preparation, team eligibility, and review into separate jobs.
- Add a team-membership helper and a read-only GitHub App token profile.
- Add tests and update the automation test workflow’s path filters.
| File | Description |
|---|---|
.github/workflows/github-automation-tests.yml |
Runs tests when the membership helper changes. |
.github/workflows/devflow-pr-review.yml |
Gates reviews on team membership. |
.github/tests/test_create_github_app_token.js |
Tests the new token permissions. |
.github/tests/test_check_team_membership.js |
Tests eligibility behavior. |
.github/scripts/check_team_membership.js |
Checks team membership. |
.github/actions/github-app-token/create-token.js |
Adds the team-check permission profile. |
.github/actions/github-app-token/action.yml |
Documents the new profile input. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
SergeyMenshykh
had a problem deploying
to
github-app-auth
September 29, 2026 13:53 — with
GitHub Actions
Failure
westey (westey-m)
approved these changes
Sep 29, 2026
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation and Context
DevFlow currently starts PR reviews for all contributors. Align its review eligibility with Microsoft Agent Framework by checking membership in the internal developer team before running the review.
Description
prepare_pr,team_check, andreviewjobs. The review runs only when the team check succeeds.DEVELOPER_TEAM, plus ateam-checkGitHub App token profile with member and PR read permissions.