Repository navigation
Python: Exclude incompatible cryptography release on Python 3.10 - #14508
SergeyMenshykh wants to merge 2 commits into
Conversation
Exclude cryptography 50.0.2 only on Python versions below 3.11 because the release has no compatible wheel or source distribution. Keep the lockfile in sync without changing locked package versions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The narrow exclusion is consistent between the manifest and lockfile and addresses the reported installation failure.
Review effort: Balanced
Findings: None
What changed in this PR
This PR keeps Python 3.10 dependency installation working by excluding an incompatible cryptography release, without restricting Python 3.11 or newer.
Changes:
- Excludes
cryptography==50.0.2on Python versions below 3.11. - Synchronizes the lockfile with the new dependency constraint.
| File | Description |
|---|---|
python/uv.lock |
Records the Python-version-specific cryptography constraint. |
python/pyproject.toml |
Adds the exclusion to project dependencies. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
MAF Automated Review — Iteration 1
Result: No findings
Scope: full PR (1 commit(s)): 56eede4aa9ec
Model: gpt-5.6-sol
Overview
The PR adds a Python 3.10-only exclusion for one incompatible cryptography release and synchronizes the generated uv lock metadata. The project Python floor, matching manifest/lock markers, and Python 3.10 upgrade-resolution CI constrain the change as intended, and no Critical, High, or Medium defect was established.
Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.
Use uv 0.5.31 in all setup-uv steps instead of the 0.5.x range. Exact version selection bypasses the GitHub releases-list lookup that repeatedly fails with Server Error, while preserving the current uv series and existing action version. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Pull request was closed
Motivation and Context
The Python 3.10 unit-test and coverage jobs for #14506 fail during dependency installation, before tests run:
Both workflows upgrade dependencies with
uv sync -Uand selectcryptography==50.0.2. Although the release metadata permits Python >=3.9, its published files contain neither a Python 3.10-compatible wheel nor a source distribution. This is independent of the MCP tool-name changes.Description
Add
cryptography!=50.0.2; python_version < '3.11'to the project dependencies and synchronize the lockfile's dependency entries. This preserves Python 3.10 support while leaving Python 3.11 and newer unrestricted. No locked package versions or unrelated artifact metadata change.Focused validation using the workflows' uv 0.5.x series:
cryptography==50.0.1.cryptography==50.0.2.git diff --checkpassed.The full unit-test suite was not run; this change only affects dependency selection.
Contribution Checklist